Merged
Conversation
… patterns warnings
Comment on lines
100
to
118
| pub fn arm(&mut self) { | ||
| if self.ejection_enable.is_high() { | ||
| info!("arm ejection enabled"); | ||
| self.arming.main.set_high(); | ||
| self.arming.main_b.set_high(); | ||
|
|
||
| self.arming.drogue.set_high(); | ||
| self.arming.main_b.set_high(); | ||
| } | ||
| } | ||
|
|
||
| pub fn disarm(&mut self) { | ||
| info!("arm ejection disabled"); | ||
| self.arming.main.set_low(); | ||
| self.arming.main_b.set_low(); | ||
|
|
||
| self.arming.drogue.set_low(); | ||
| self.arming.main_b.set_low(); | ||
| } |
Contributor
There was a problem hiding this comment.
Any reason to call self.arming.main_b.set_low(); and self.arming.main_b.set_high(); in rapid succession? like that?
drogue_b?
Comment on lines
187
to
199
| // --- Spawning Tasks --- | ||
| // spawner.must_spawn(led_blinker_task(p.PB14)); | ||
|
|
||
| // spawner.must_spawn(uart_dma_reader_task(ring_rx)); | ||
| // spawner.must_spawn(uart_gps_dma_reader_task(ring_gps_rx, gps_tx)); | ||
| // spawner.must_spawn(sbg_parser_task(tx)); | ||
| // spawner.must_spawn(sbg_receiver_task()); | ||
| // spawner.must_spawn(baro_reader_task(baro)); | ||
| // spawner.must_spawn(ai_task()); | ||
| // pass control of the spawner to the state machine | ||
| // spawner.must_spawn(sm_task(spawner, state_machine)); | ||
| spawner.must_spawn(radio_reader_task(radio_ring_rx)); | ||
| spawner.must_spawn(radio_writer_task(radio_tx)); |
Contributor
There was a problem hiding this comment.
Why not uncomment and use #[cfg(feature = "gps")], sbg, baro etc? Just set the default features being all the ones we will be using.
If you want to make experiments just use cargo run --features "gps-ublox" (or gps-nmea) etc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.